Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Retrieve translation of color settings strings #4479

Merged
merged 5 commits into from
Jan 19, 2022
Merged

[RNMobile] Retrieve translation of color settings strings #4479

merged 5 commits into from
Jan 19, 2022

Conversation

wpmobilebot
Copy link
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 17, 2022 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot self-assigned this Jan 17, 2022
@fluiddot fluiddot added the [Type] Bug Something isn't working label Jan 17, 2022
@fluiddot fluiddot requested review from geriux and jhnstn January 17, 2022 16:19
@fluiddot fluiddot added this to the 1.70.0 (19.1) milestone Jan 17, 2022
@fluiddot
Copy link
Contributor

Hey @fluiddot , we will cut the 1.70.0 release on January 20th. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.70.0, thanks 🙇.

@fluiddot fluiddot mentioned this pull request Jan 18, 2022
Merged
8 tasks
geriux
geriux approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#38026 (review)

@fluiddot fluiddot enabled auto-merge January 19, 2022 17:17
@fluiddot fluiddot merged commit c1d6f4b into develop Jan 19, 2022
@fluiddot fluiddot deleted the version-toolkit/gutenberg/rnmobile/fix/translate-color-settings-strings branch January 19, 2022 17:42
This was referenced Jan 19, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

@jhnstn jhnstn Awaiting requested review from jhnstn

Assignees

@fluiddot fluiddot

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.70.0 (19.1)
Development

Successfully merging this pull request may close these issues.
3 participants
@wpmobilebot @fluiddot @geriux