Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRC visual regression on live templates #137

Closed
Mai-Saad opened this issue Sep 6, 2024 · 3 comments · Fixed by #145
Closed

LRC visual regression on live templates #137

Mai-Saad opened this issue Sep 6, 2024 · 3 comments · Fixed by #145
Assignees

Comments

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Sep 6, 2024

Scenario: Shouldn't cause visual regression when visiting x template
Given: 3.17+ is active
And: Visit x page
When: clear cache
And: visit the page
then: no visual regression compared to nowprocket

Templates:
delayjs_1.3_live_template.php
delayjs_68_live_template.php
page lcp_6647_live.php
lcp_live_4_template.php
lcp_live_test_span.php
rucss_5213_template.php
template 4787.php
lrc_will_site.php

@Mai-Saad Mai-Saad changed the title LRC visual regression on live temlates LRC visual regression on live templates Sep 6, 2024
@MathieuLamiot
Copy link
Contributor

Looks like we might already have all the needed code, and we just need to put together test scenarios with list of files to test against?

See the step I must not see any visual regression

@jeawhanlee
Copy link
Contributor

Scope a solution ✅

  • Add the new templates for VR testing to the SCENARIO_URLS in wp.config.ts
  • Create a new feature with a new tag with steps to install new_release, visit page, clear cache and perform backstop reference comparison.

Estimate the effort ✅

[S]

For Added context, we need to make some changes to the way we create references, as all urls in SCENARIO_URLS will be created as references which for most regression tests, we will not tests all references but rather just a few, take for example this current grooming, if we are to add the new templates to the SCENARIO_URLS we will have other templates there in the object that will not be tested for that test cycle simple because we don't need to.

I added an issue for this here @MathieuLamiot

@MathieuLamiot
Copy link
Contributor

Thanks @jeawhanlee. I added your issue to the cooldown board. Up to @wp-media/qa-team and you to decide what needs to be prioritized first among those E2E visual regression issues :)

@Khadreal Khadreal self-assigned this Sep 13, 2024
Khadreal added a commit that referenced this issue Sep 18, 2024
Mai-Saad added a commit that referenced this issue Oct 17, 2024
Closes #137 LRC visual regression on live templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants