Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #137 LRC visual regression on live templates #145

Merged
merged 18 commits into from
Oct 17, 2024

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #137

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

Allow QA to test for any visual regression on LRC templates

Technical description

Documentation

Allow QA to test for any visual regression on LRC templates

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Khadreal Khadreal self-assigned this Sep 18, 2024
@Khadreal Khadreal marked this pull request as ready for review September 23, 2024 16:54
@Khadreal Khadreal requested a review from a team September 23, 2024 16:54
Miraeld
Miraeld previously approved these changes Sep 24, 2024
src/features/lrc-visual-regression.feature Outdated Show resolved Hide resolved
src/support/steps/general.ts Outdated Show resolved Hide resolved
src/support/steps/general.ts Outdated Show resolved Hide resolved
@jeawhanlee
Copy link
Contributor

Currently backstop tests are not running well, because of my comment here

@Khadreal Khadreal requested a review from jeawhanlee September 24, 2024 10:29
jeawhanlee
jeawhanlee previously approved these changes Sep 24, 2024
jeawhanlee
jeawhanlee previously approved these changes Sep 26, 2024
@Khadreal Khadreal requested a review from jeawhanlee September 30, 2024 20:01
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Oct 4, 2024

@Khadreal Thanks for the PR

  • test itself is passing
  • backstop for VR (4passes/8) => Note for lcp_live_4 , removed recaptcha js so that it works {pushed to test repo}
  • Now failed templates that may need update or removal:
    delayjs_1-3_live_template
    lcp_live_test_span
    rucss_5213_template
    lrcWillSite

Screenshot from 2024-10-04 13-35-33
Screenshot from 2024-10-04 13-35-28
Screenshot from 2024-10-04 13-35-24
Screenshot from 2024-10-04 13-35-20
Screenshot from 2024-10-04 13-35-16
Screenshot from 2024-10-04 13-35-12
Screenshot from 2024-10-04 13-35-08
Screenshot from 2024-10-04 13-35-04
Screenshot from 2024-10-04 13-33-28

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Oct 10, 2024

@Khadreal
Copy link
Contributor Author

I did another round of test and the plugin was removed when the test was running. @jeawhanlee could help run the test when you have some time.

@jeawhanlee
Copy link
Contributor

I can confirm with @Khadreal that the plugin will be removed from the env if it was already installed before running tests.

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Oct 17, 2024

opened another ticket for the uninstall issue #153

Copy link
Contributor

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle failed templated can be on other PR #154

@Mai-Saad Mai-Saad merged commit 1a6694c into develop Oct 17, 2024
2 checks passed
@Mai-Saad Mai-Saad deleted the enhancement/137-vr-on-template branch October 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LRC visual regression on live templates
4 participants