Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Should links be clickable While Delay JS is enabled" is always failing because of waiting for getByRole('link', { name: 'About Us' }) #167

Closed
MathieuLamiot opened this issue Nov 16, 2024 · 4 comments · Fixed by #170
Assignees
Labels
effort: [XS] < 1 day of estimated development time enhancement New feature or request

Comments

@MathieuLamiot
Copy link
Contributor

No description provided.

@jeawhanlee
Copy link
Contributor

@MathieuLamiot On this one, I'm not sure there's anything to be done here, the reason this is failing is because the delayjs test requires specific scripts:

  • test:delayjs:genesis
  • test:delayjs:flatsome
  • test:delayjs:divi
  • test:delayjs:astra

I ran npm run test:delayjs:flatsome on the remote desktop and it passes.

@MathieuLamiot
Copy link
Contributor Author

We need to do something to don't have a failed test:

  • Ideally, can the correct behavior be set in the "all tests" command? I don't know what makes the commands you mention special. Can't we run them as part of the complete test plan?
  • If this is not possible, then the test must be excluded of the complete test plan. This is not ideal of course.

In any case, something needs to be done.

@jeawhanlee
Copy link
Contributor

We can encapsulate this kind of test to be run with a single command like we do for WP Rocket here. That would be a straight forward solution.

@jeawhanlee
Copy link
Contributor

Scope a solution ✅

There are 2 ways I see to handle this

Method 1

Create a new script

  • Create an array to hold all script command and loop through them.

In https://github.com/wp-media/wp-rocket-e2e/blob/221c9d21605df18c9a96cb65509f71480f01cefa/package.json

  • Update the value of this script to hold the path to the new script just created

Method 2

In

"test:e2e": "$npm_package_config_testCommand",

  • Chain all the scripts in a single command using &&

Estimate the effort
[XS]

@jeawhanlee jeawhanlee self-assigned this Nov 19, 2024
@jeawhanlee jeawhanlee added enhancement New feature or request effort: [XS] < 1 day of estimated development time labels Nov 20, 2024
Mai-Saad added a commit that referenced this issue Nov 28, 2024
…en-run-globally

Closes #167: "Should links be clickable While Delay JS is enabled" is always failing because of waiting for getByRole('link', { name: 'About Us' })
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time enhancement New feature or request
Projects
None yet
2 participants