Closes #167: "Should links be clickable While Delay JS is enabled" is always failing because of waiting for getByRole('link', { name: 'About Us' }) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miraeld
previously approved these changes
Nov 21, 2024
… and updated this object to accomodate pickle prop
… other step definitions from using SCENARIO_URLS
…x/176-error-with-backstop-test-for-llcssbg-and-lrc
16 tasks
|
@jeawhanlee Thanks for the PR. can see 2 tests failing (one related to DJS). can you please check 🙏 |
…x/176-error-with-backstop-test-for-llcssbg-and-lrc
|
Delayjs tests are green now when run npm run test:delayjs (we need to update config file manually to match the sample file here) LLCSSBG results (note: backstop results still 0 passed, 0 failed, if this is handled on other GH then we are good) |
Mai-Saad
previously approved these changes
Nov 28, 2024
Miraeld
previously approved these changes
Nov 28, 2024
wordpressfan
previously approved these changes
Nov 28, 2024
|
when run e2e , 5 failed (4 related to error in debug.log that shall be ignored and 1 timeout to be checked later) |
…t-for-llcssbg-and-lrc Closes #176: Backstop tests not working as expected for LLCSSBG & LRC tests when run generally
Mai-Saad
dismissed stale reviews from wordpressfan, Miraeld, and themself
via
2aeba3d
Mai-Saad
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make delayjs test compatible with general test run.
Fixes #167
Explain how this code impacts users.
Type of change
Detailed scenario
Running
npm run test:e2eon develop should trigger the error.Technical description
Documentation
Updates delayjs test to run with general test run as expected, by removing multiple runs for various themes and switching to run with scenario outlines and also moving backstop reference creation from BeforeAll hooks to step defintion.
New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style