Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errorprone config for Java 10 #1265

Merged
merged 4 commits into from
Aug 11, 2018

Conversation

AustinShalit
Copy link
Member

Basically followed the instructions here: google/error-prone#860

@auscompgeek if you wouldn't mind checking this.

@auscompgeek
Copy link
Member

Well, it builds on Java 10. Can't say the same for the CI running Java 8 though.

@AustinShalit
Copy link
Member Author

Yea... I think I just fixed that. If you wouldn't mind trying again.

@auscompgeek
Copy link
Member

Works on Java 10, but CI still seems unhappy. :(

@AustinShalit
Copy link
Member Author

Oops. I missed a critical piece of docs: "Error Prone requires at least a JDK 9 compiler to be used as a javac plugin." So this should be merged when we decide to go to Java 10.

@auscompgeek
Copy link
Member

I guess we can deal with the warnings until that happens then.

@ThadHouse
Copy link
Member

Is there no way to support both Java 8 and Java 10? We kind of want both to be supported by the build setup.

@AustinShalit
Copy link
Member Author

The trusty if statement worked well here

Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@PeterJohnson PeterJohnson merged commit 44099d9 into wpilibsuite:master Aug 11, 2018
@AustinShalit AustinShalit deleted the java10_errorprone branch August 11, 2018 05:38
@tbroyer
Copy link

tbroyer commented Sep 2, 2018

Note: net.ltgt.errorprone-javacplugin version 0.5 now works out of the box with JDK 8 (you just have to configure an errorproneJavac dependency to com.google.errorprone:javac) so you no longer need to conditionally switch between two plugins (and two ways of configuring Error Prone).
This will become the next version of net.ltgt.errorprone (so be prepared to switch again in a few weeks/months, back to net.ltgt.errorprone; only the plugin ID will change)

@AustinShalit
Copy link
Member Author

Awesome! We'll keep an eye out for that.

pjbuterbaugh pushed a commit to pjbuterbaugh/allwpilib that referenced this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants