rx-html (feature): Reduce tag/attr name conflicts with SVG #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerial
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3076 +/- ##
==========================================
- Coverage 82.84% 82.83% -0.01%
==========================================
Files 350 349 -1
Lines 14677 14675 -2
Branches 2446 2498 +52
==========================================
- Hits 12159 12156 -3
- Misses 2518 2519 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
xerial
commented
Jul 28, 2023
| @@ -170,8 +170,7 @@ trait Tags { | |||
| lazy val summary: HtmlElement = tag("summary") | |||
| // Defines superscripted text | |||
| lazy val sup: HtmlElement = tag("sup") | |||
| // Defines a container for SVG graphics | |||
| lazy val svg: HtmlElement = tag("svg") | |||
There was a problem hiding this comment.
svg needs to be scoped in SVG namespace, so this definition is useless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.