Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rx-html (feature): Reduce tag/attr name conflicts with SVG #3076

Merged
merged 2 commits into from
Jul 28, 2023
Merged

rx-html (feature): Reduce tag/attr name conflicts with SVG #3076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc2ba9a
rx-html (fix): Reduce tag/attr name conflicts with SVG
xerial Jul 28, 2023
2cde839
Add note
xerial Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airframe-rx-html/src/main/scala/wvlet/airframe/rx/html/Attrs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ trait WindowEventAttrs extends SharedEventAttrs {
/**
* Script to be run when a user navigates to a page
*/
lazy val onpageshow = attr("onpageshow")
lazy val onpageshow: HtmlAttributeOf = attr("onpageshow")

/**
* Script to be run when the window's history changes
Expand Down
9 changes: 6 additions & 3 deletions airframe-rx-html/src/main/scala/wvlet/airframe/rx/html/SvgAttrs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,14 +520,16 @@ trait SvgAttrs {
/**
* MDN
*/
lazy val height = attr("height")
// Conflicts with Attr.height
// lazy val height = attr("height")

/**
* MDN
*/
lazy val imageRendering = attr("imageRendering")

lazy val id = attr("id")
// id is already available in Attrs
// lazy val id = attr("id")

/**
* MDN
Expand Down Expand Up @@ -995,7 +997,8 @@ trait SvgAttrs {
*
* MDN
*/
lazy val width = attr("width")
// width conflicts with Attr.width
// lazy val width = attr("width")

/*
*
Expand Down
Loading
Loading