[Directory.Build.props] Add $(_DefaultTargetFrameworks). #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moljac
approved these changes
Apr 1, 2023
jpobst
added a commit
to xamarin/GooglePlayServicesComponents
that referenced
this pull request
May 5, 2023
Context: xamarin/AndroidX#712 Although we don't currently build and ship GPS for `net7.0` or `net8.0`, it is a good test exercise to run `generator` against GPS to ensure we aren't creating any regressions in `generator`. To do this, we currently have to change the `TargetFrameworks` in many places. Instead, let's put the default `TargetFrameworks` to build in `Directory.Build.props`, so it only has to be changed in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we don't currently build and ship AndroidX for
net7.0ornet8.0, it is a good test exercise to rungeneratoragainst AndroidX to ensure we aren't creating any regressions ingenerator.To do this, we currently have to change the
TargetFrameworksin ~16 templates.Instead, let's put the default
TargetFrameworksto build inDirectory.Build.props, so it only has to be changed in one place.Note that projects (like
Xamarin.AndroidBinderator.csproj) can continue to explicitly specify their TF(s) if they need to.