Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Directory.Build.props] Add $(_DefaultTargetFrameworks). #712

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 30, 2023

Although we don't currently build and ship AndroidX for net7.0 or net8.0, it is a good test exercise to run generator against AndroidX to ensure we aren't creating any regressions in generator.

To do this, we currently have to change the TargetFrameworks in ~16 templates.

Instead, let's put the default TargetFrameworks to build in Directory.Build.props, so it only has to be changed in one place.

Note that projects (like Xamarin.AndroidBinderator.csproj) can continue to explicitly specify their TF(s) if they need to.

@jpobst jpobst marked this pull request as ready for review March 30, 2023 21:42
@jpobst jpobst requested a review from moljac March 30, 2023 21:42
@jpobst jpobst merged commit 5c728f4 into main Apr 3, 2023
@jpobst jpobst deleted the target-frameworks branch April 3, 2023 14:04
jpobst added a commit to xamarin/GooglePlayServicesComponents that referenced this pull request May 5, 2023
Context: xamarin/AndroidX#712

Although we don't currently build and ship GPS for `net7.0` or `net8.0`, it is a good test exercise to run `generator` against GPS  to ensure we aren't creating any regressions in `generator`.

To do this, we currently have to change the `TargetFrameworks` in many places.

Instead, let's put the default `TargetFrameworks` to build in `Directory.Build.props`, so it only has to be changed in one place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants