Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Directory.Build.props] Add $(_DefaultTargetFrameworks). #764

Merged
merged 1 commit into from
May 5, 2023

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented May 2, 2023

Context: xamarin/AndroidX#712

Although we don't currently build and ship GPS for net7.0 or net8.0, it is a good test exercise to run generator against GPS to ensure we aren't creating any regressions in generator.

To do this, we currently have to change the TargetFrameworks in many places.

Instead, let's put the default TargetFrameworks to build in Directory.Build.props, so it only has to be changed in one place.

@jpobst jpobst marked this pull request as ready for review May 4, 2023 13:56
@jpobst jpobst requested a review from moljac May 4, 2023 13:56
Copy link
Member

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpobst jpobst merged commit 6e2374a into main May 5, 2023
@jpobst jpobst deleted the targetframeworks branch May 5, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants