Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Revert #8090 Android scrollbar flashes #10447

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Revert #8090 Android scrollbar flashes #10447

merged 1 commit into from
Apr 27, 2020

Conversation

jfversluis
Copy link
Member

Description of Change

Reverts the changes of #8090. Caused too much regression on other controls inside of a ScrollView. Reverting the changes for now and reopening #8015 to find a new solution for the initial problem.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

No more scrollbar flashes on controls in a ScrollView. On the other hand, the ScrollView scrollbar visibility will be broken again,

Before/After Screenshots

Not applicable

Testing Procedure

There are multiple scenarios where you can find this. You can go to the Material Entry gallery and whenever you focus one entry you see the scrollbar flash on the right.

If you go to the label gallery and go through the MaxLines cases you will also see a scrollbar flash.

With this change, that should not be visible anymore

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jfversluis
Copy link
Member Author

CollectionView uses this same concept. Note to self; check if the scrollbar flashing happens there as well

@samhouts samhouts merged commit bb6ea96 into 4.5.0 Apr 27, 2020
@samhouts samhouts deleted the revert-8090 branch April 27, 2020 21:34
@samhouts samhouts modified the milestones: 4.6.0, 4.5.0 Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants