This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Fix ScrollView visibility issue #10659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
changed the title
samhouts
approved these changes
May 28, 2020
|
@jsuarezruiz Can you see if this PR fixes #10882, and if so, retarget to 4.6.0? Thanks! |
samhouts
reviewed
Jun 2, 2020
|
After the E.Z changes in this PR #10893, I am going to refactor this one a little bit to apply the same changes. |
samhouts
reviewed
Jun 2, 2020
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
samhouts
added
4.4.0
hartez
approved these changes
Jun 29, 2020
|
@jsuarezruiz It looks like this might also fix #7629? |
jsuarezruiz
force-pushed
the
fix-droid-scrollvisibility
branch
from
8ac2936
to
a63feb2
Compare
jsuarezruiz
removed
the
DO-NOT-MERGE-!!! 🛑
|
Applied changes based on the E.Z changes in #10893. |
samhouts
approved these changes
Jul 7, 2020
samhouts
added
the
approved
|
The failing tests on Android concern me. :( |
jsuarezruiz
added
the
DO-NOT-MERGE-!!! 🛑
|
@samhouts Added the "DO-NOT-MERGE-!!!" label until review the failing tests. |
samhouts
added
the
retarget-branch-required
samhouts
added
DO-NOT-MERGE-!!! 🛑
|
Failing test doesn't seem related |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In this PR #8090 was added the support to be able to manage the visibility of the scrollbar in the ScrollView on Android. However, this PR added a repeated issue, the scrollbar visibility the child elements of the ScrollView when initializing (or refreshing). For this reason, this PR #10447 revert original one changes.
This PR recovers the initial changes to allow managing the visibility of the scrollbar in ScrollView but also avoiding the issue with the child elements.
The problem was in the used Context. When creating
ScrollViewRendererwe were creating a context that used a custom style (using vertical and horizontal scrollbars). This context was used creatingScrollViewContainer. So by defaultScrollViewContainerhadVerticalScrollBarEnabledset to true (incorrect!).Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Before
After
Testing Procedure
Launch Core Gallery. Navigate to the "ScrollView Gallery" to verify that can hide/show the ScrollView toolbar. Also, navigate to the "Material Entry Gallery" (for example) and set the focus on different Entries to validate that the "flickering scrollbar" issue in the ScrollView children's is fixed.
PR Checklist