Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Remove XFCorePostProcessorCodeInjected #12096

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Remove XFCorePostProcessorCodeInjected #12096

merged 1 commit into from
Sep 18, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Sep 11, 2020 •
edited by samhouts
Loading

Description of Change

This projects injects IL to maintain XF 2.5 compatibility. We're far enough away from XF 2.5 now that this weaving should no longer be necessary

#2880

Testing Procedure

  • UI Tests pass

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

rmarinho
rmarinho approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests not related

@PureWeen PureWeen merged commit dacfe47 into 5.0.0 Sep 18, 2020
@PureWeen PureWeen deleted the remove_XFCorePostProcessorCodeInjected branch September 18, 2020 15:13
@samhouts samhouts added this to the 5.0.0 milestone Sep 19, 2020
@samhouts samhouts added breaking Changes behavior or appearance API-change Heads-up to reviewers that this PR may contain an API change deprecation Public API has been deprecated m/high impact ⬛ proposal-open t/enhancement ➕ roadmap labels Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner

@samhouts samhouts Awaiting requested review from samhouts

Assignees

@StephaneDelcroix StephaneDelcroix

@samhouts samhouts

Labels
a/Xaml </> API-change Heads-up to reviewers that this PR may contain an API change breaking Changes behavior or appearance Core deprecation Public API has been deprecated m/high impact ⬛ proposal-open roadmap t/enhancement ➕
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Spec] Major Breaking Changes Proposed for Xamarin.Forms 5.0
4 participants
@PureWeen @rmarinho @StephaneDelcroix @samhouts