Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[build] post-build fix of the assembly #2880

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Conversation

StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented May 31, 2018

Description of Change

[build] post-build fix of the assembly

add the IL corresponding to the old signature of the getter of ResourceLoader.ResourceProvider so code compiled against prior versions do not fail.

@alanmcgovern: could you please

  • confirm that the previewer looks for the ResourceProvider using the full signature, and not only the name
  • confirm that the old signature was never used, and it's safe not to implement the setter

Bugs Fixed

API Changes

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@alanmcgovern
Copy link
Contributor

Can you remind me where the package shows up? Is it gonna be linked on this PR?

@jassmith
Copy link

ShameHat is adorable but no... bad name

@jassmith
Copy link

Also do we need all these dlls checked in?

@StephaneDelcroix
Copy link
Member Author

ShameHat is adorable but no... bad name

meh, yes

Also do we need all these dlls checked in?
@jassmith we do not need the dll checked in, we could build the tool as part of our process

@alanmcgovern
Copy link
Contributor

alanmcgovern commented May 31, 2018

jr03569-ygp900_1_lar

Works for me!

Copy link
Contributor

@alanmcgovern alanmcgovern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine for me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants