Skip to content

Commit

Permalink
Wrap mono_gc_init_finalizer_thread() call with now-needed coop GC sta…
Browse files Browse the repository at this point in the history
…te transition. (#8248)

Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode.

Should fix mono/mono#19372

Co-authored-by: Alexis Christoforides <alexis@thenull.net>
  • Loading branch information
monojenkins and alexischr authored Mar 31, 2020
1 parent aa73e41 commit 3e4fd79
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions runtime/monotouch-main.m
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@ - (void) start
{
// COOP: ?
#if defined (__arm__) || defined(__aarch64__)
MONO_ENTER_GC_UNSAFE;
mono_gc_init_finalizer_thread ();
MONO_EXIT_GC_UNSAFE;
#endif
}

Expand Down

3 comments on commit 3e4fd79

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on 3e4fd79 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 177 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed -> Known failure: HE0038

Ok 🤥

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on 3e4fd79 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥

Test results

4 tests failed, 138 tests passed.

Failed tests

  • dont link/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): HarnessException (Harness exception for 'dont link': System.Net.Sockets.SocketException (0x80004005): Could not resolve host 'XI-SCARLET-WITCH' -> DNS Network failure
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed -> https://github.com/xamarin/maccore/issues/1626
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Failed -> https://github.com/xamarin/maccore/issues/1907
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed -> https://github.com/xamarin/maccore/issues/1626

Ok 🤥

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on 3e4fd79 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on TvOS on Azure DevOps(TvOS): Html Report 🔥

Test results

# Test run in progress: Building: 1, Running: 1, RunQueued: 115, Succeeded: 18, Ignored: 1069, TimedOut: 7

Failed tests

  • monotouch-test/tvOS - device/Debug: TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug): TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug): TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: dylib (debug, profiling): TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (debug, profiling): TimedOut
  • monotouch-test/tvOS - device/Release: TimedOut
  • monotouch-test/tvOS - device/AssemblyBuildTarget: SDK framework (release): TimedOut

Fail - Bot Halted

Please sign in to comment.