[threading] embedded mono hangs #16907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When embedded mono is executing a C++ code, it didn't start to execute a C# code, we don't need to suspend the thread to run GC. Fixes mono#16192 Fixes mono#14725
lambdageek
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
- Needs some comments. Also a better commit message explaining the embedding scenario that we want to protect.
- Could you try also to mark
mono_jit_initandmono_jit_init_versionasMONO_RT_EXTERNAL_ONLYinjit.h- I think they're unused in the runtime - they're only for embedders. - I would just get rid of the cookie in
MONO_ENTER_GC_SAFE_UNBALANCEDand deleteMONO_EXIT_GC_SAFE_UNBALANCED.
mono/mini/driver.c
Outdated
| @@ -2754,7 +2754,9 @@ mono_main (int argc, char* argv[]) | |||
| MonoDomain * | |||
| mono_jit_init (const char *file) | |||
| { | |||
| return mini_init (file, NULL); | |||
| MonoDomain *ret = mini_init (file, NULL); | |||
| MONO_ENTER_GC_SAFE_UNBALANCED; | |||
There was a problem hiding this comment.
I think we need a comment here to explain why we want to leave this thread in GC Safe mode.
mono/mini/driver.c
Outdated
| @@ -2780,7 +2782,9 @@ mono_jit_init (const char *file) | |||
| MonoDomain * | |||
| mono_jit_init_version (const char *domain_name, const char *runtime_version) | |||
| { | |||
| return mini_init (domain_name, runtime_version); | |||
| MonoDomain *ret = mini_init (domain_name, runtime_version); | |||
| MONO_ENTER_GC_SAFE_UNBALANCED; | |||
mono/utils/mono-threads-api.h
Outdated
| MONO_STACKDATA (__gc_safe_unbalanced_dummy); \ | ||
| gpointer __gc_safe_unbalanced_cookie = mono_threads_enter_gc_safe_region_unbalanced_internal (&__gc_safe_unbalanced_dummy) | ||
|
|
||
| #define MONO_EXIT_GC_SAFE_UNBALANCED \ | ||
| mono_threads_exit_gc_safe_region_unbalanced_internal (__gc_safe_unbalanced_cookie, &__gc_safe_unbalanced_dummy); \ | ||
| } while (0) | ||
| mono_threads_exit_gc_safe_region_unbalanced_internal (__gc_safe_unbalanced_cookie, &__gc_safe_unbalanced_dummy); |
There was a problem hiding this comment.
it seems like this macro has almost no value: it won't compile unless you pair it with MONO_ENTER_GC_SAFE_UNBALANCED (because it needs the cookie). But if you use it like that, it's balanced!
|
|
@monojenkins build failed |
lambdageek
approved these changes
Sep 24, 2019
|
@monojenkins build failed |
1 similar comment
|
@monojenkins build failed |
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
* [threading] embedded mono hangs When embedded mono is executing a C++ code, it didn't start to execute a C# code, we don't need to suspend the thread to run GC. Fixes mono/mono#16192 Fixes mono/mono#14725 * Changing what was discussed with Aleksey during our 1on1 * Changing what was suggested by Aleksey * Separating mono_init_version that is being used on tests from the embedded ones Commit migrated from mono/mono@5b108b5
alexischr
added a commit
to xamarin/xamarin-macios
that referenced
this pull request
Mar 30, 2020
…te transition. Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode. Should fix mono/mono#19372
rolfbjarne
pushed a commit
to xamarin/xamarin-macios
that referenced
this pull request
Mar 31, 2020
…te transition. (#8242) Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode. Should fix mono/mono#19372
monojenkins
pushed a commit
to monojenkins/xamarin-macios
that referenced
this pull request
Mar 31, 2020
…te transition. Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode. Should fix mono/mono#19372
monojenkins
pushed a commit
to monojenkins/xamarin-macios
that referenced
this pull request
Mar 31, 2020
…te transition. Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode. Should fix mono/mono#19372
monojenkins
pushed a commit
to monojenkins/xamarin-macios
that referenced
this pull request
Mar 31, 2020
…te transition. Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode. Should fix mono/mono#19372
rolfbjarne
pushed a commit
to xamarin/xamarin-macios
that referenced
this pull request
Mar 31, 2020
…te transition. (#8245) Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode. Should fix mono/mono#19372 Co-authored-by: Alexis Christoforides <alexis@thenull.net>
mandel-macaque
pushed a commit
to xamarin/xamarin-macios
that referenced
this pull request
Mar 31, 2020
…te transition. (#8248) Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode. Should fix mono/mono#19372 Co-authored-by: Alexis Christoforides <alexis@thenull.net>
alexischr
added a commit
that referenced
this pull request
Apr 1, 2020
Starting with #16907 , the runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. mono_gc_init_finalizer_thread() expects the GC to not already be in safe mode.
alexischr
added a commit
to alexischr/runtime
that referenced
this pull request
Apr 1, 2020
Starting with mono/mono#16907 , the runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. mono_gc_init_finalizer_thread() expects the GC to not already be in safe mode.
This was referenced Apr 1, 2020
akoeplinger
pushed a commit
to dotnet/runtime
that referenced
this pull request
Apr 1, 2020
Starting with mono/mono#16907 , the runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. mono_gc_init_finalizer_thread() expects the GC to not already be in safe mode.
akoeplinger
pushed a commit
that referenced
this pull request
Apr 1, 2020
Starting with #16907 , the runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. mono_gc_init_finalizer_thread() expects the GC to not already be in safe mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When embedded mono is executing a C++ code, it didn't start to execute a C# code, we don't need to suspend the thread to run GC.
So my idea is set the flag MONO_THREAD_INFO_FLAGS_NO_GC when initializes mono embedded and only remove the flag MONO_THREAD_INFO_FLAGS_NO_GC when a mono_runtime_invoke_array or a mono_runtime_invoke is called.
Fixes #16192
Fixes #14725