Skip to content

Commit

Permalink
Wrap mono_gc_init_finalizer_thread() call with now-needed coop GC sta…
Browse files Browse the repository at this point in the history
…te transition. (#8245)

Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode.

Should fix mono/mono#19372

Co-authored-by: Alexis Christoforides <alexis@thenull.net>
  • Loading branch information
monojenkins and alexischr authored Mar 31, 2020
1 parent 3601ac3 commit 89652e2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions runtime/monotouch-main.m
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@ - (void) start
{
// COOP: ?
#if defined (__arm__) || defined(__aarch64__)
MONO_ENTER_GC_UNSAFE;
mono_gc_init_finalizer_thread ();
MONO_EXIT_GC_UNSAFE;
#endif
}

Expand Down

4 comments on commit 89652e2

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 Experimental DDFun pipeline

🔥 Device tests completed (Failed) on iOS-DDFun on Azure DevOps(iOS-DDFun) 🔥

🔥 Tests failed catastrophically (no summary found)

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on 89652e2 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 182 tests passed.

Failed tests

Ok 🤥

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Device tests passed on iOS on Azure DevOps(iOS): Html Report

🎉 All 150 tests passed 🎉

@xamarin-release-manager
Copy link
Collaborator

@xamarin-release-manager xamarin-release-manager commented on 89652e2 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on TvOS on Azure DevOps(TvOS): Html Report 🔥

Test results

# Test run in progress: Building: 1, BuildQueued: 140, Ignored: 1111, TimedOut: 9

Failed tests

  • monotouch-test/tvOS - device/Debug: TimedOut
  • framework-test/tvOS - device/Debug: TimedOut
  • interdependent-binding-projects/tvOS - device/Debug: TimedOut
  • fsharp/tvOS - device/Debug: TimedOut
  • dont link/tvOS - device/Debug: TimedOut
  • link all/tvOS - device/Debug: TimedOut
  • link sdk/tvOS - device/Debug: TimedOut
  • mono-native-compat/tvOS - device/Debug: TimedOut
  • mono-native-unified/tvOS - device/Debug: TimedOut

Fail - Bot hung up

Please sign in to comment.