Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect changes from int to (unsigned) long in the runtime #7509

Closed
rolfbjarne opened this issue Nov 28, 2019 · 3 comments · Fixed by #7529
Closed

Incorrect changes from int to (unsigned) long in the runtime #7509

rolfbjarne opened this issue Nov 28, 2019 · 3 comments · Fixed by #7529
Assignees
@mandel-macaque
Labels
bug If an issue is a bug or a pull request a bug fix iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac
Milestone
Future

Comments

@rolfbjarne
Copy link
Member

The native long and unsigned long are 64-bit on a 64-bit OS and 32-bit on a 32-bit OS.

This means that this change is incorrect: 2e5b648#diff-ef40c5787a0475f88e10461efe5f3c01L55-R55

Any (unsigned) int -> (unsigned) long commits must be fully reviewed again, there are several other places where there are bugs:

2e5b648#diff-ef40c5787a0475f88e10461efe5f3c01L206-R206

2e5b648#diff-5ca7e9836bcee437c268d6065e2c6eaeL26-R26 (breaking API change)

2e5b648#diff-a41cda5f508168c4aafab2b33741eed4L384-R384 (breaking API change)

2e5b648#diff-ba72c2a1b404212ae58242dc25660defL12-R13 (breaking API change - this one actually causes the link all tests to crash when run on a device in release mode)

2e5b648#diff-6ddca81e8497599c1b02b643c8ed5128L29-R29 (breaking API change)

2e5b648#diff-ae96dff46e2db1f319d0331d9beed8d2L184-R184 (breaking API change)

2e5b648#diff-0689f45915b28af398ed3ac8f5d98545L38-R38 (breaking API change)
@rolfbjarne rolfbjarne added bug If an issue is a bug or a pull request a bug fix macOS Issues affecting Xamarin.Mac iOS Issues affecting Xamarin.iOS labels Nov 28, 2019
@rolfbjarne rolfbjarne added this to the Future milestone Nov 28, 2019
xamarin-release-manager referenced this issue Nov 28, 2019
@rolfbjarne
[xharness] Make sure to always stop log and system capture. (#7499)
0f8bb77 
This will hopefully stop the runaway mlaunch processes we've seen on the bots.

Ref: xamarin/maccore#1965.
xamarin-release-manager referenced this issue Nov 28, 2019
@monojenkins @mandel-macaque
[d16-5] [Tests] Update tests.sln to include all the BCL tests. (#7480)
9f95d86 
Update the UUIDs of the projects to ensure that they are all present
in the sln for developers to use.

Fixes: #7475
Fixes: #7476
@rolfbjarne
Copy link
Member Author

This also causes https://github.com/xamarin/maccore/issues/2072.

xamarin-release-manager referenced this issue Dec 2, 2019
@spouliot
[linker] Fix "Linked Away" exceptions with Thread.CurrentPrincipal. Fix
845e757 
#7321 (#7510)

Keep 'CallContextSecurityData' around since it's quite small (and the
normal linker logic will be able to deal with it if unused) and allows
the use of `Thread.CurrentPrincipal`

Also add unit test.

Fix #7321
mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this issue Dec 2, 2019
@mandel-macaque
[Runtime] Move some of the changes back to int.
352a48e 
Some of the fixes done for the warnings have breaking changes. Move back
to int and ensure that we do not have any compilation errors (we are
using -Werror).

Fixes: xamarin#7509
@mandel-macaque mandel-macaque mentioned this issue Dec 2, 2019
Merged
xamarin-release-manager referenced this issue Dec 3, 2019
@rolfbjarne
[monotouch-test] Make NetworkReachabilityTest.CtorIPAddressPair a bit…
bc67353 
… more permissive. Fixes xamarin/maccore#2047. (#7516)

Try to fix xamarin/maccore#2047 by making the test
accept NetworkReachabilityFlags.Reachable for the loopback address on device.

Fixes xamarin/maccore#2047.
xamarin-release-manager referenced this issue Dec 3, 2019
@monojenkins @rolfbjarne
Bump macios-binaries to get fix for xamarin/maccore#2068. (#7511)
fb95daa 
New commits in xamarin/macios-binaries:

* xamarin/macios-binaries@eb6980e Bump mlaunch to xamarin/maccore@92433b7757 (#28)

Diff: https://github.com/xamarin/macios-binaries/compare/6f488dd1322706a319c674ac35a4988c3f6ea89e..eb6980e8b6ee7bcd6edfd514e606b664bd93f33d
xamarin-release-manager referenced this issue Dec 4, 2019
@akoeplinger
Put back skipping of test on OSX 10.10
0c957d2
xamarin-release-manager referenced this issue Dec 4, 2019
@rolfbjarne
[xibuild] Clean up temporary files when done. (#7508)
4586171
xamarin-release-manager referenced this issue Dec 4, 2019
@monojenkins @rolfbjarne
[xharness] Make sure to always stop log and system capture. (#7503)
5c5112e 
This will hopefully stop the runaway mlaunch processes we've seen on the bots.

Ref: xamarin/maccore#1965.
xamarin-release-manager referenced this issue Dec 5, 2019
@rolfbjarne
[monotouch-test] Improve MessageHandlerTest.TestNSUrlSessionHandlerCo…
e19fd5b 
…okies. (#7542)

1. Instead of fetching the managed response's cookies twice, and then
   comparing them to themselves, fetch the managed response's cookies once and
   then the native response's cookies once, and compare that. This way the
   test does what it's actually supposed to do!
2. Don't pass if we fail to get the managed response's cookies.
3. Improve assertions to verify the actual cookie content as well.
4. Improve diagnostics if an exception was thrown by checking for the
   exception first instead of failing due to something else being different
   (since the underlying cause of the difference is the exception, that's what
   will have the most information about the failure).
5. Use httpbin.org instead of microsoft.com, since microsoft.com does UA
   sniffing and returns different results between the http handlers :/
mandel-macaque added a commit that referenced this issue Dec 12, 2019
@mandel-macaque
[Runtime] Move some of the changes back to int. (#7529)
3f0985e 
Some of the fixes done for the warnings have breaking changes. Move back
to int and ensure that we do not have any compilation errors (we are
using -Werror).

Fixes: #7509
@rolfbjarne rolfbjarne mentioned this issue Dec 12, 2019
Merged
xamarin-release-manager referenced this issue Dec 13, 2019
@monojenkins @rolfbjarne
[d16-5] [vsts-1029041] Add FileType to the list of parameters for alt…
fa7e040 
…ool (#7563)

* [vsts-1029041] Add FileType to the list of parameters for altool

* ValidateAppStoreBundle
* UploadAppStoreBundle

* [vsts-1029041] Pass TargetFrameworkIdentifier to identify target platform
@spouliot
Copy link
Contributor

@mandel-macaque it needs to be backported to d16-5 since we still have test failures in that branch

@spouliot spouliot reopened this Dec 13, 2019
mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this issue Dec 16, 2019
@mandel-macaque
[Runtime] Move some of the changes back to int. (xamarin#7529)
1cfca98 
Some of the fixes done for the warnings have breaking changes. Move back
to int and ensure that we do not have any compilation errors (we are
using -Werror).

Fixes: xamarin#7509
@mandel-macaque mandel-macaque mentioned this issue Dec 16, 2019
Merged
mandel-macaque added a commit that referenced this issue Dec 17, 2019
@mandel-macaque
[Runtime] Move some of the changes back to int. (#7529) (#7606)
c44e339 
Some of the fixes done for the warnings have breaking changes. Move back
to int and ensure that we do not have any compilation errors (we are
using -Werror).

Fixes: #7509
@spouliot
Copy link
Contributor

Some stuff was indirectly backported to d16-5 (thru a merge) and that's why the above backport was also needed. Now merged so those errors should be gone...

@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mandel-macaque mandel-macaque

Labels
bug If an issue is a bug or a pull request a bug fix iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[Runtime] Move some of the changes back to int. mandel-macaque/xamarin-macios
3 participants
@rolfbjarne @spouliot @mandel-macaque