[net8.0] Merge main into net8.0 #18770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using reflection in the managed static registrar (xamarin#18519) This PR adds lookup tables and factory methods for INativeObjects and NSObjects. These generated methods allow us to create instances of these objects without needing reflection. Closes xamarin#18358.
The .mobile.props file is a file created and written by the mobile VS extension to store property values that needs to be read early enough in the build chain, as in design time builds, and that can't be set by CPS because of a limitation in the project system. See more information here: xamarin/XamarinVS#13606 Initially it was named .user.env file and then was renamed in another PR as part of a feedback from the project system team. See more information here: xamarin/XamarinVS#13628 Because this file was saved in the intermediate output path, it was meant to be imported automatically by MSBuild, however we recently detected that this was not happening reliably. Because of this, some things like C# Hot Reload for iOS stopped working because Roslyn was reading incorrect values from the Design Time Builds. For that reason and to avoid relying on the project system, I'm importing this file explicitly (and removing old .user.env import), so the values in the file are always available and the dependent properties are calculated correctly and available for all the consumers (including Roslyn). This should fix the following bugs: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1822041 https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1851677
…8570. (xamarin#18724) This is a bit non-obvious, but we later use the presence of such a stored list to determine if we need to generate the __Registrar__ type in the assembly. The problem is that we need to generate the __Registrar__ type even if no trampolines were created, because we use it for numerous other purposes as well (type lookup for instance). Fixes xamarin#18570.
* Remove unusued code. * Rename method to make it follow the common TryGet... pattern.
…#18722) XDocument.Load(string) takes a URI, not a file path. This usually works if there are no special characters in the file path, but for instance with a path with a colon (say 'a:b/some/file'), we'll get an exception about invalid uri scheme. So instead use the XDocument.Load(Stream) overload, and create the stream using the file path instead, in which case there's no problem with special characters.
…ding projects / assemblies. (xamarin#18683)
… it doesn't bubble up to the CI. (xamarin#18723) This seems to happen fairly often: + xcrun simctl diagnose -b -X --output=/Users/builder/azdo/_work/1/s/diagnostic-sim-output/output Error creating archive at '/Users/builder/azdo/_work/1/s/diagnostic-sim-output/output.tar.gz'. Files are still in /Users/builder/azdo/_work/1/s/diagnostic-sim-output/output An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=17): Unable to write or file already exists File exists The output directory is empty (created in the line before), so I have no idea what's going on. An archive with the diagnostic info still seems to be created though, so just ignore any failures from 'simctl diagnose' instead of bubbling them up to Azure DevOps. This makes our test runs not show up with warnings.
…ironment variables. (xamarin#18738) Setting test configuration variables using the environment is useful when running tests on a Windows machine (easier than having to deal with make). Also refactor the code a bit to not use constants, and more consistent naming.
…on Windows. (xamarin#18737) This makes it easier to run some tests on Windows, because the tests reference this file and by having it checked in it doesn't need to be generated (which we currently do using make, which isn't trivial on Windows). Also adjust the generated output slightly to make it easier on the eyes.
filipnavara
requested review from
rolfbjarne,
mandel-macaque,
dalexsoto,
emaf and
mauroa
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…c and not trimmed
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
|
@filipnavara sorry I don't have bandwidth atm to go deeper into the failures apart from providing the logs to you, hope this is fine:
|
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 227 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
approved these changes
Aug 22, 2023
rolfbjarne
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR: #18742 with workaround for dotnet/runtime#90800