[d15-4][mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #58778. (#2501) #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8778. (xamarin#2501) We need the 'mono_profiler_startup_log' symbol when profiling is enabled, so make sure to add the symbol to the correct list of symbols we need. Previously we were passing `-u _mono_profiler_startup_log` to clang directly, which is fine, but not complete, since it does not write the symbol to the symbollist file (--symbollist=file), which means it wouldn't be preserved when the MSBuild tasks strip the executable. https://bugzilla.xamarin.com/show_bug.cgi?id=58778
|
Build success |
spouliot
added
the
requires-approval-before-merge
|
@Aguilex -> same as the one for SR3 but for 15.4 |
spouliot
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the 'mono_profiler_startup_log' symbol when profiling is enabled, so
make sure to add the symbol to the correct list of symbols we need.
Previously we were passing
-u _mono_profiler_startup_logto clang directly,which is fine, but not complete, since it does not write the symbol to the
symbollist file (--symbollist=file), which means it wouldn't be preserved when
the MSBuild tasks strip the executable.
https://bugzilla.xamarin.com/show_bug.cgi?id=58778