Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #58778. #2501

Merged
merged 1 commit into from
Aug 18, 2017
Merged

[mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #58778. #2501

merged 1 commit into from
Aug 18, 2017

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Aug 17, 2017 •
edited
Loading

We need the 'mono_profiler_startup_log' symbol when profiling is enabled, so make
sure to add the symbol to the correct list of symbols we need.

Previously we were passing -u _mono_profiler_startup_log to clang directly,
which is fine, but not complete, since it does not write the symbol to the
symbollist file (--symbollist=file), which means it wouldn't be preserved when
the MSBuild tasks strip the executable.

https://bugzilla.xamarin.com/show_bug.cgi?id=58778

@rolfbjarne
[mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #5…
84bbb35 
…8778.

We need the 'mono_profiler_startup_log' symbol when profiling is enabled, so
make sure to add the symbol to the correct list of symbols we need.

Previously we were passing `-u _mono_profiler_startup_log` to clang directly,
which is fine, but not complete, since it does not write the symbol to the
symbollist file (--symbollist=file), which means it wouldn't be preserved when
the MSBuild tasks strip the executable.

https://bugzilla.xamarin.com/show_bug.cgi?id=58778
@rolfbjarne rolfbjarne force-pushed the dont-strip-profiler-symbols branch from b074595 to 84bbb35 Compare August 17, 2017 14:39
@monojenkins
Copy link
Collaborator

Build failure

1 similar comment
@monojenkins
Copy link
Collaborator

Build failure

@rolfbjarne
Copy link
Member Author

git clone failure 😒

@rolfbjarne
Copy link
Member Author

build

@monojenkins
Copy link
Collaborator

Build success

@rolfbjarne rolfbjarne merged commit f60801b into xamarin:master Aug 18, 2017
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Aug 22, 2017
@rolfbjarne
[mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #5…
d95da98 
…8778. (xamarin#2501)

We need the 'mono_profiler_startup_log' symbol when profiling is enabled, so
make sure to add the symbol to the correct list of symbols we need.

Previously we were passing `-u _mono_profiler_startup_log` to clang directly,
which is fine, but not complete, since it does not write the symbol to the
symbollist file (--symbollist=file), which means it wouldn't be preserved when
the MSBuild tasks strip the executable.

https://bugzilla.xamarin.com/show_bug.cgi?id=58778
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Aug 22, 2017
@rolfbjarne
[mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #5…
0cfd717 
…8778. (xamarin#2501)

We need the 'mono_profiler_startup_log' symbol when profiling is enabled, so
make sure to add the symbol to the correct list of symbols we need.

Previously we were passing `-u _mono_profiler_startup_log` to clang directly,
which is fine, but not complete, since it does not write the symbol to the
symbollist file (--symbollist=file), which means it wouldn't be preserved when
the MSBuild tasks strip the executable.

https://bugzilla.xamarin.com/show_bug.cgi?id=58778
Aguilex added a commit that referenced this pull request Aug 22, 2017
@Aguilex
Merge pull request #2520 from rolfbjarne/bug58778-d15-3
912171f 
[d15-3][mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #58778. (#2501)
Aguilex added a commit that referenced this pull request Aug 23, 2017
@Aguilex
Merge pull request #2521 from rolfbjarne/bug58778-d15-4
43c281b 
[d15-4][mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #58778. (#2501)
spouliot added a commit that referenced this pull request Sep 12, 2017
@spouliot
Merge latest d15-3 fixes into xcode9 (#2660)
6e91809 
* [msbuild] Re-added wildcard (*) expandsion for application-identifier in Entitlements.plist (#2186)

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=57119

* Bump mono (#2213)

* Framework tests were still binding non-linked Simple class which errors now (#2216) (#2218)

- Improve Makefile to rebuild when projects build with errors

* Bump mono to get cecil fix for bug #56808. (#2222)

https://bugzilla.xamarin.com/show_bug.cgi?id=56808

* [msbuild] Use @(ReferencePath) instead of @(ResolvedFiles) (#2188) (#2214)

This allows things to work on both xbuild and msbuild.

In xbuild, both lists are exactly the same and on msbuild,
only @(ReferencePath) exists.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=55147

* NSActivityOptions.IdleDisplaySleepDisabled had wrong value (#2232) (#2239)

This was due to an integer overflow.  The original value was based on Int32
1 << 40 == 256

The correct value should be based on a UInt64.
1UL << 40 == 1099511627776

* [tests] Fix bug 57699 - [iOS]InternalsTest failure (Linkall) tests on device (#2243)

Strip native debugging symbols should not be checked for debug builds

* Bump mono to get fix for bug #57780.

https://bugzilla.xamarin.com/show_bug.cgi?id=57780

* Update .gitmodules

Change branch to d15-3 branch of mono

* Bump maccore to get fix for bug #55064.

https://bugzilla.xamarin.com/show_bug.cgi?id=55064

* [mono] Bump mono to get the head of cecil/mono-2017-04 and fix IsComObject #57919

Also fix #58789 [1], the typo in tools/mtouch/Tuning.cs showing in MT0000 errors
instead MT2102. That's already in master and d15-4

mono bump includes:

[2] commit 2a6502cee0df9de5198eafe7c8b5f6ac25106f34 (HEAD -> d15-3, origin/d15-3)
Merge: 02457c20fcf 5e05cafc6f1
Author: Luis Aguilera <luis.aguilera@xamarin.com>
Date:   Fri Aug 18 10:04:06 2017 -0400

    Merge pull request #5401 from marek-safar/com

    [Marshal.IsComObject] Make this predicate return false instead of thr…

[3] commit 02457c20fcf57c0610e844d638eb1da82b5d1eb0
Merge: da80840ea55 73fd9a1b82e
Author: Luis Aguilera <luis.aguilera@xamarin.com>
Date:   Fri Aug 18 09:59:06 2017 -0400

    Merge pull request #5400 from spouliot/bump-cecil-58834-d15-3

    [cecil] Bump to the head of the mono-2017-04 branch and pick the fix for bug #58834

References
[1] https://bugzilla.xamarin.com/show_bug.cgi?id=58789
[2] https://bugzilla.xamarin.com/show_bug.cgi?id=57919
[3] https://bugzilla.xamarin.com/show_bug.cgi?id=58834

* [mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #58778. (#2501)

We need the 'mono_profiler_startup_log' symbol when profiling is enabled, so
make sure to add the symbol to the correct list of symbols we need.

Previously we were passing `-u _mono_profiler_startup_log` to clang directly,
which is fine, but not complete, since it does not write the symbol to the
symbollist file (--symbollist=file), which means it wouldn't be preserved when
the MSBuild tasks strip the executable.

https://bugzilla.xamarin.com/show_bug.cgi?id=58778

* Bump versions for SR3

https://trello.com/c/EVze08ei

* Bump mono to include HttpClientHandler fix #44027

https://trello.com/c/jYFXadH8/8-systemnethttp-close-request-stream-when-httpclienthandler
https://bugzilla.xamarin.com/show_bug.cgi?id=44027
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
@rolfbjarne
Bump maccore.
b83edf3 
New commits in xamarin/maccore:

* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)

Diff: https://github.com/xamarin/maccore/compare/8bb7dc6c38f40cab45fd916f082d794313b0855d..62e6757515dc46b3a99bfbc348932f25861f27bd
@rolfbjarne rolfbjarne mentioned this pull request Aug 26, 2021
Merged
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
@rolfbjarne
Bump maccore. (#12557)
58ae71b 
* Bump maccore.

New commits in xamarin/maccore:

* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)

Diff: https://github.com/xamarin/maccore/compare/8bb7dc6c38f40cab45fd916f082d794313b0855d..62e6757515dc46b3a99bfbc348932f25861f27bd

* Bump again.

New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)

Diff: https://github.com/xamarin/maccore/compare/62e6757515dc46b3a99bfbc348932f25861f27bd..3e591cbcb15081d34a9512ca39d9df55c331bdbd
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
@rolfbjarne
Bump maccore.
048c3a5 
New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)
* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)
* xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498)
* xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497)

Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd
@rolfbjarne rolfbjarne mentioned this pull request Aug 26, 2021
Merged
rolfbjarne added a commit that referenced this pull request Aug 27, 2021
@rolfbjarne @dalexsoto
Bump maccore. (#12559)
172c420 
New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)
* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)
* xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498)
* xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497)

Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd

Co-authored-by: Alex Soto <alex@alexsoto.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rolfbjarne @monojenkins @spouliot @dnfclas