[xharness] Don't try to find simulators for ignored tests. #6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to find a simulator will mark the test as a failure if the simulator couldn't be found, and we don't want that to happen to ignored tests. This should fix an issue where xharness seems to try to run the 32-bit simulator tests when asked to run only device tests.
spouliot
approved these changes
May 23, 2019
dalexsoto
approved these changes
May 23, 2019
|
Build success |
mandel-macaque
approved these changes
May 23, 2019
|
@monojenkins backport d16-2 |
|
@monojenkins backport xcode11 |
|
@monojenkins backport d16-3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to find a simulator will mark the test as a failure if the simulator
couldn't be found, and we don't want that to happen to ignored tests.
This should fix an issue where xharness seems to try to run the 32-bit
simulator tests when asked to run only device tests.