[d16-2] [xharness] Don't try to find simulators for ignored tests. #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to find a simulator will mark the test as a failure if the simulator couldn't be found, and we don't want that to happen to ignored tests. This should fix an issue where xharness seems to try to run the 32-bit simulator tests when asked to run only device tests.
rolfbjarne
added
the
pr-change-not-shipping
rolfbjarne
approved these changes
Jun 26, 2019
|
Build success |
dalexsoto
approved these changes
Jun 26, 2019
mandel-macaque
approved these changes
Jul 4, 2019
|
Approved for d16-2 as test only change. |
rolfbjarne
added
the
requires-approval-before-merge
spouliot
added a commit
that referenced
this pull request
Aug 14, 2019
* [tests] Handle Xcodes without proper versions by ignoring them. Fixes xamarin/maccore#1768. (#6386) This can happen if an Xcode hasn't been completely/successfully installed or removed. Fixes https://github.com/xamarin/maccore/issues/1768. * [CoreGraphics] Fix lifetime of delegates passed to CGPatternCreate. (#6368) We may get callbacks after the managed CGPattern instance has been disposed/garbage collected, so make sure our delegates survives that long. Since the delegates don't need any instance state, just make them static. * [d16-2] Bump mono to pick tz/DST fixes.. (#6454) * [xharness] Don't try to find simulators for ignored tests. (#6421) Trying to find a simulator will mark the test as a failure if the simulator couldn't be found, and we don't want that to happen to ignored tests. This should fix an issue where xharness seems to try to run the 32-bit simulator tests when asked to run only device tests. * [tests] Only call MTLDevice.CreateSharedTexture macOS 10.14+. Fixes xamarin/maccore#1663. (#6423) Fixes https://github.com/xamarin/maccore/issues/1663. * [d16-2] [GameController] GCGamepad is deprecated in the headers, so mark it as such. Fixes xamarin/maccore#1742. (#6428) * [GameController] GCGamepad is deprecated in the headers, so mark it as such. Fixes xamarin/maccore#1742. Fixes https://github.com/xamarin/maccore/issues/1742. * Add attribute for tvOS too. * [package] Remove creation of files/symlinks under /Developer (#6665) * [d16-2] [tests] wrench is long gone (#6698) * [tests] wrench is long gone * Use a different Url that works and ensure we get a nice message when we have a failure. * Fix new callback test. * Ignore the outgenerated projects until they are moved to their own dir. (#6714) Related issue #6162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to find a simulator will mark the test as a failure if the simulator
couldn't be found, and we don't want that to happen to ignored tests.
This should fix an issue where xharness seems to try to run the 32-bit
simulator tests when asked to run only device tests.
Backport of #6116.
/cc @rolfbjarne