-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[d16-6]Bump to mono:2020-02 #8161
[d16-6]Bump to mono:2020-02 #8161
Conversation
Bump mono to 2020-02 head to be in sync with Android. Co-authored-by: Imran Hameed <imhameed@microsoft.com> Co-authored-by: Sebastien Pouliot <sebastien.pouliot@microsoft.com> Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: Sebastien Pouliot <sebastien.pouliot@gmail.com>
Build failure 🔥 Build failed 🔥 |
@@ -125,8 +125,8 @@ void ProcessMethod (MethodDefinition method) | |||
} | |||
} | |||
|
|||
if (MarkStep.IsPropertyMethod (method)) { | |||
var property = MarkStep.GetProperty (method); | |||
if (method.IsPropertyMethod ()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious - why were these code changes necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use external source from monolinker repo - which is not quite API stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in the API of the linker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Build failure Test results5 tests failed, 166 tests passed.Failed tests
|
@monojenkins backport d16-6-xcode11.4 |
@dalexsoto backporting to d16-6-xcode11.4 failed, the patch results in conflicts:
Please backport manually! |
Bump mono to 2020-02 head to be in sync with Android.
Co-authored-by: Imran Hameed imhameed@microsoft.com
Co-authored-by: Sebastien Pouliot sebastien.pouliot@microsoft.com
Co-authored-by: Ankit Jain radical@gmail.com
Co-authored-by: Manuel de la Pena mandel@microsoft.com
Co-authored-by: Sebastien Pouliot sebastien.pouliot@gmail.com