Fix nfs if there is xenbr0 as public_network, remove nokogiri dependency, update REDME #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can be configured in /etc/exports
chenull
changed the title
|
This looks nice. It would be nice to test on Ubuntu (or Debian) and CentOS flavor, but other than that, it looks really good. |
|
@jonludlam Any chance to bring these changes in? There are some good improvements here in documentation. |
|
Nobody seems to be working on this - please re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is my first ever code in ruby, so please review / test it. feel free to discard my PR, and use your own implementation so the same result can be achieved. I've tested in Windows 7, Windows 10, and Mac OS 10.9 (maverick), but not linux.
This PR will fix issue #18
and i think PR #27 is not needed anymore since actually i don't see nokogiri's calls inside the
prepare_nfs_settings.rbcode.Thanks