Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] wrong specified states for IKEA 1744? #105

Closed
liselotte111 opened this issue Jul 29, 2020 · 8 comments
Closed

[BUG] wrong specified states for IKEA 1744? #105

liselotte111 opened this issue Jul 29, 2020 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@liselotte111
Copy link

liselotte111 commented Jul 29, 2020

Bug report

Description

My IKEA 1744 did not work. I checked ikea.py and saw "brightness_move_down" in stead of "rotate_left". Same for all the other states. I changed all the states to the ones reported by zigbee2mqtt. But might be easier for others if you changed it?

class E1744MediaPlayerController(MediaPlayerController):
    # Different states reported from the controller:
    # brightness_move_down, brightness_move_up, brightness_stop,
    # toggle, brightness_step_up, brightness_step_down


    def get_z2m_actions_mapping(self) -> TypeActionsMapping:
        return {
            "rotate_left": MediaPlayer.HOLD_VOLUME_DOWN,
            "rotate_right": MediaPlayer.HOLD_VOLUME_UP,
            "rotate_stop": MediaPlayer.RELEASE,
            "play_pause": MediaPlayer.PLAY_PAUSE,
            "skip_forward": MediaPlayer.NEXT_TRACK,
            "skip_backward": MediaPlayer.PREVIOUS_TRACK,
        }

Additional information

  • Devices involved:
    • Model: [IKEA 1744 ] as [Media Player]
    • ...
  • Integration: mqtt
  • AppDaemon version: [v4.0.3 ]
  • ControllerX version: [v3.3.0]

AppDaemon app configuration

volumeknop2:
  module: controllerx
  class: E1744MediaPlayerController
  controller: zigbee2mqtt/0xec1bbdfffe8b8e02/action
  integration: mqtt
  media_player: media_player.denon_ceol
  volume_steps: 25
  delay: 150
@liselotte111 liselotte111 added the bug Something isn't working label Jul 29, 2020
@liselotte111 liselotte111 changed the title [BUG] [BUG] wrong specified states for IKEA 1744? Jul 29, 2020
@xaviml
Copy link
Owner

xaviml commented Jul 30, 2020

Hi @liselotte111

Sorry to hear about this. Which version of Zigbee2MQTT are you currently using? I received a PR (#96) from @fedebruni84 to change the mapping for that controller because it changed in the latest version of Z2M. Maybe @fedebruni84 will know better about this as well.

Thanks,
Xavi M.

xaviml added a commit that referenced this issue Aug 3, 2020
@xaviml
Copy link
Owner

xaviml commented Aug 3, 2020

Hi again,

@mvjt confirmed in #103 that the current mapping is correct for the latest stable z2m version. The only thing it was not done was to update the ControllerX documentation for the E1744 device, which I just update and it will be reflected for next release.

@liselotte111
Copy link
Author

liselotte111 commented Aug 3, 2020 via email

@fedebruni84
Copy link
Contributor

Hi @liselotte111, have you tried to add "legacy: false" to the z2m config?

@liselotte111
Copy link
Author

liselotte111 commented Aug 3, 2020 via email

@xaviml
Copy link
Owner

xaviml commented Aug 5, 2020

Hi guys, just to clarify myself and also to document it, if the legacy: false is not in place, then the actions are the old ones (rotate_left, rotate_right, skip_forward, etc). Is this right? If so, I will document this to advice to set legacy: false, which I hope in the future comes by default, this is why is legacy.

Cheers,
Xavi M.

@liselotte111
Copy link
Author

liselotte111 commented Aug 5, 2020 via email

@xaviml
Copy link
Owner

xaviml commented Aug 17, 2020

Documentation has been updated with this information: https://xaviml.github.io/controllerx/controllers/E1744

@xaviml xaviml closed this as completed Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants