Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Dedup #450

Closed
wants to merge 11 commits into from
Closed

Fix/Dedup #450

wants to merge 11 commits into from

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Sep 14, 2023

Base on #466

Please briefly answer these questions:

Described in #439, When solving the issue of SP GC, the first step is to handle cmd deduplication and determine if it is complete.

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 318 lines in your changes are missing coverage. Please review.

Comparison is base (fe5b7de) 54.17% compared to head (ba97d3a) 53.98%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   54.17%   53.98%   -0.19%     
==========================================
  Files         101      103       +2     
  Lines       18239    18979     +740     
  Branches    18239    18979     +740     
==========================================
+ Hits         9881    10246     +365     
- Misses       7768     8142     +374     
- Partials      590      591       +1     
Files Coverage Δ
curp-test-utils/src/test_cmd.rs 76.19% <100.00%> (+0.30%) ⬆️
curp/src/lib.rs 100.00% <ø> (ø)
curp/src/server/cmd_board.rs 37.59% <100.00%> (+4.52%) ⬆️
curp/src/server/gc.rs 85.29% <ø> (+0.08%) ⬆️
xline-client/src/clients/auth.rs 0.00% <ø> (ø)
curp/src/error.rs 7.89% <0.00%> (-0.68%) ⬇️
curp/src/server/raw_curp/tests.rs 77.03% <82.75%> (+0.65%) ⬆️
curp/src/server/raw_curp/mod.rs 68.00% <86.27%> (+0.75%) ⬆️
curp/src/server/client_lease.rs 87.87% <87.87%> (ø)
curp/src/tracker.rs 91.84% <91.84%> (ø)
... and 5 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iGxnon iGxnon marked this pull request as ready for review September 28, 2023 03:09
@iGxnon iGxnon marked this pull request as draft October 18, 2023 01:39
@iGxnon iGxnon marked this pull request as ready for review November 3, 2023 05:51
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
@iGxnon iGxnon marked this pull request as draft November 21, 2023 03:54
@iGxnon iGxnon closed this by deleting the head repository Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant