refactor: refactor propose id into <client_id>#<seq_num>
#466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 54.13% 54.13%
=======================================
Files 102 102
Lines 17512 17526 +14
Branches 17512 17526 +14
=======================================
+ Hits 9480 9488 +8
- Misses 7465 7472 +7
+ Partials 567 566 -1
☔ View full report in Codecov by Sentry. |
Closed
bsbds
reviewed
Oct 7, 2023
Phoenix500526
previously approved these changes
Oct 8, 2023
bsbds
reviewed
Oct 9, 2023
Signed-off-by: iGxnon <igxnon@gmail.com>
bsbds
approved these changes
Oct 9, 2023
Phoenix500526
added
the
Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
This PR refactors ProposeId into
<client_id>#<seq_num>, The client_id will be generated by the lease manager(not implemented in this PR), and the seq_num will ensure that all IDs are unique and ordered under the same client_id.what changes does this pull request make?
As above
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No