-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/replace curp client #585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
===========================================
+ Coverage 64.40% 79.74% +15.34%
===========================================
Files 105 157 +52
Lines 18802 21994 +3192
Branches 18802 0 -18802
===========================================
+ Hits 12109 17539 +5430
+ Misses 5955 4455 -1500
+ Partials 738 0 -738 ☔ View full report in Codecov by Sentry. |
iGxnon
force-pushed
the
refactor/curp-client-3
branch
from
January 3, 2024 05:55
99bc9b6
to
e4246af
Compare
bsbds
reviewed
Jan 5, 2024
iGxnon
force-pushed
the
refactor/curp-client-3
branch
from
January 5, 2024 04:46
0f898e5
to
fec91f8
Compare
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
iGxnon
force-pushed
the
refactor/curp-client-3
branch
from
January 9, 2024 02:15
fec91f8
to
a4fe329
Compare
bsbds
reviewed
Jan 9, 2024
bsbds
approved these changes
Jan 9, 2024
themanforfree
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #582 , replace CurpClient
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)