Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/replace curp client #585

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Dec 21, 2023

Base on #582 , replace CurpClient

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@iGxnon iGxnon changed the title Refactor/curp client replace Refactor/replace curp client Dec 21, 2023
@iGxnon iGxnon marked this pull request as draft December 21, 2023 14:29
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 298 lines in your changes are missing coverage. Please review.

Comparison is base (fa656ad) 64.40% compared to head (a4fe329) 79.74%.
Report is 52 commits behind head on master.

Files Patch % Lines
curp/src/client/unary.rs 86.88% 67 Missing ⚠️
curp/src/rpc/connect.rs 60.71% 33 Missing ⚠️
curp/src/client/tests.rs 92.59% 30 Missing ⚠️
xline/src/server/kv_server.rs 45.45% 18 Missing ⚠️
xline/src/storage/compact/mod.rs 0.00% 16 Missing ⚠️
curp/src/server/mod.rs 54.54% 15 Missing ⚠️
xline/src/storage/compact/periodic_compactor.rs 41.66% 14 Missing ⚠️
xline/src/storage/compact/revision_compactor.rs 46.15% 14 Missing ⚠️
xline-client/src/clients/kv.rs 67.50% 13 Missing ⚠️
curp/src/client/retry.rs 92.50% 12 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #585       +/-   ##
===========================================
+ Coverage   64.40%   79.74%   +15.34%     
===========================================
  Files         105      157       +52     
  Lines       18802    21994     +3192     
  Branches    18802        0    -18802     
===========================================
+ Hits        12109    17539     +5430     
+ Misses       5955     4455     -1500     
+ Partials      738        0      -738     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Phoenix500526 Phoenix500526 added this to the v0.6.1 milestone Jan 2, 2024
@iGxnon iGxnon marked this pull request as ready for review January 4, 2024 12:57
curp/src/client/tests.rs Show resolved Hide resolved
curp/src/rpc/mod.rs Show resolved Hide resolved
curp/src/server/mod.rs Show resolved Hide resolved
xline/src/server/mod.rs Outdated Show resolved Hide resolved
xline/src/storage/compact/mod.rs Outdated Show resolved Hide resolved
curp/src/client/mod.rs Outdated Show resolved Hide resolved
curp/src/client/unary.rs Show resolved Hide resolved
curp/src/server/raw_curp/mod.rs Show resolved Hide resolved
xline/src/storage/compact/periodic_compactor.rs Outdated Show resolved Hide resolved
xline/src/storage/compact/revision_compactor.rs Outdated Show resolved Hide resolved
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Copy link
Collaborator

@themanforfree themanforfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6ebc04a into xline-kv:master Jan 9, 2024
9 checks passed
@iGxnon iGxnon deleted the refactor/curp-client-3 branch January 10, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants