fix: curp wal #854
Merged
fix: curp wal #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsbds Convert your pr to draft since CI failed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 75.55% 75.36% -0.20%
==========================================
Files 180 190 +10
Lines 26938 28203 +1265
Branches 26938 28203 +1265
==========================================
+ Hits 20353 21254 +901
- Misses 5366 5627 +261
- Partials 1219 1322 +103 ☔ View full report in Codecov by Sentry. |
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Jun 17, 2024
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Phoenix500526
approved these changes
Jun 20, 2024
|
LGTM |
CrystalAnalyst
previously approved these changes
Jun 21, 2024
Phoenix500526
requested changes
Jun 24, 2024
|
@Mergifyio rebase |
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> fix(wal): disable pipeline background tasks for madsim The background task will block as madsim is single threaded Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> refactor(wal): improve encoding performance Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com> chore: use constants instead of magic Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
wal-refactor
branch
from
591c0ee
to
05d0f58
Compare
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Jul 12, 2024
Signed-off-by: bsbds <69835502+bsbds@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #687
Some fixes and improvements for the WAL storage
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)