Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link provider hover doesn't go away when mouse leaves xterm element or document #2849

Closed
Tyriar opened this issue Apr 16, 2020 · 2 comments · Fixed by #2856
Closed

Link provider hover doesn't go away when mouse leaves xterm element or document #2849

Tyriar opened this issue Apr 16, 2020 · 2 comments · Fixed by #2856
Assignees
@Tyriar
Labels
area/links type/bug Something is misbehaving
Milestone
4.6.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 16, 2020

Mouse is within editor:

image

Can also happen when mousing out of the document quickly.
@Tyriar Tyriar added type/bug Something is misbehaving area/links labels Apr 16, 2020
@jmbockhorst
Copy link
Contributor

This doesn't seem reproducible to me after the latest changes in xterm and vscode.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 19, 2020

I've done a bunch of work around this and there's still a WIP PR out microsoft/vscode#95608

For leaving the xterm element I fixed it in #2852, I'm currently still working through an issue where the link in sticky when the mouse leaves the document though which looks like it could get fixed in xterm.js.

@Tyriar Tyriar mentioned this issue Apr 19, 2020
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 19, 2020
@Tyriar
Prevent hover callbacks firing if the mouse is outside the viewport
1282c06 
Fixes xtermjs#2849
@Tyriar Tyriar mentioned this issue Apr 19, 2020
Merged
@Tyriar Tyriar self-assigned this Apr 19, 2020
@Tyriar Tyriar added this to the 4.6.0 milestone Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/links type/bug Something is misbehaving
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

Prevent hover callbacks firing if the mouse is outside the viewport Tyriar/xterm.js
2 participants
@Tyriar @jmbockhorst