Fix Rails 7.1 deprecation warning #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEPRECATION WARNING: `connection_pool_list` currently only applies to connection pools in the current role (`writing`). In Rails 7.2, this method will apply to all known pools, regardless of role. To affect only those connections belonging to a specific role, pass the role name as an argument. To switch to the new behavior, pass `:all` as the role name. (called from block (2 levels) in <module:ActiveRecord> at /Users/jacopobeschi/.rbenv/versions/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/yabeda-activerecord-0.1.0/lib/yabeda/active_record.rb:74)
intrip
force-pushed
the
fix-rails71-deprecatin
branch
from
b21c252 to
29df0a3
Compare
intrip
commented
Nov 16, 2023
| connection_pools = ::ActiveRecord::Base.connection_handler.connection_pool_list | ||
| connection_pools = \ | ||
| if Rails.version >= "7.1" | ||
| ::ActiveRecord::Base.connection_handler.connection_pool_list(:all) |
There was a problem hiding this comment.
I don't know much about this code but I assume we want to retrieve all roles here, if instead we want to only use the current role we can achieve it via ::ActiveRecord::Base.connection_handler.connection_pool_list(ActiveRecord::Base.current_role)
There was a problem hiding this comment.
I think that your assumption is correct (but not sure myself)
Envek
requested changes
Dec 12, 2023
Co-authored-by: Andrey Novikov <envek@envek.name>
Envek
requested changes
Dec 12, 2023
Co-authored-by: Andrey Novikov <envek@envek.name>
Envek
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/rails/rails/blob/7-1-stable/activerecord/lib/active_record/connection_adapters/abstract/connection_handler.rb#L294-L300