Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails 7.1 deprecation warning #4

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fix Rails 7.1 deprecation warning #4

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29df0a3
Fix Rails 7.1 deprecation warning
intrip Nov 16, 2023
41b40d8
Update lib/yabeda/active_record.rb
intrip Dec 12, 2023
544c6db
Update lib/yabeda/active_record.rb
intrip Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/yabeda/active_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,12 @@ class Error < StandardError; end

# Connection pool metrics collection
collect do
connection_pools = ::ActiveRecord::Base.connection_handler.connection_pool_list
connection_pools = \
if ::ActiveRecord.version >= "7.1"
intrip marked this conversation as resolved.
Show resolved Hide resolved
::ActiveRecord::Base.connection_handler.connection_pool_list(:all)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about this code but I assume we want to retrieve all roles here, if instead we want to only use the current role we can achieve it via ::ActiveRecord::Base.connection_handler.connection_pool_list(ActiveRecord::Base.current_role)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that your assumption is correct (but not sure myself)

else
::ActiveRecord::Base.connection_handler.connection_pool_list
end

connection_pools.each do |connection_pool|
stats = connection_pool.stat
Expand Down
Loading