[#27] Add instructions for each category #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Extracted functions related to LLM responses to response.py - Renamed the "response type" to "category" - Added instructions for each category - Blocked the submit until the user has selected a category
kangsuhyun-yanolja
requested review from
poerty,
seungduk-yanolja,
rifqiyan and
geon-yanolja
Comment on lines
+41
to
+46
| if not category: | ||
| raise gr.Error("Please select a category.") | ||
|
|
||
| if category == Category.TRANSLATE.value and (not source_lang or | ||
| not target_lang): | ||
| raise gr.Error("Please select source and target languages.") |
There was a problem hiding this comment.
This part is new
Comment on lines
+56
to
+59
| messages=[{ | ||
| "content": instruction, | ||
| "role": "system" | ||
| }, { |
There was a problem hiding this comment.
This message is new
There was a problem hiding this comment.
Hmm this is a chat style but maybe okay for now
seungduk-yanolja
approved these changes
Feb 6, 2024
|
|
||
| # To simulate a stream, we yield each character of the response. | ||
| for character in content: | ||
| yield character |
There was a problem hiding this comment.
no stream please. maybe todo? both responses must arrive together at the same time
There was a problem hiding this comment.
I'll leave TODO and handle it in #29
Comment on lines
+56
to
+59
| messages=[{ | ||
| "content": instruction, | ||
| "role": "system" | ||
| }, { |
There was a problem hiding this comment.
Hmm this is a chat style but maybe okay for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #27