Swap the modal-dialog template based on Ember version. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Ember.View` is a deprecated wrapper (triggering a deprecation on init) for the "true" Ember.View class in 1.13+. This change simplifies the logic, and uses `.element` prop if present.
|
Looks good to me. Thoughts, @lukemelia? |
|
👍 Thanks, @rwjblue! |
lukemelia
added a commit
that referenced
this pull request
Jun 18, 2015
Swap the modal-dialog template based on Ember version.
|
I tried this out with 2.0 beta and it doesn't work because |
|
Thanks @rwjblue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use library that @lukemelia and I worked on at WGE to detect the Ember version, and use a different template as needed.
Requires a release of ember-tether including yapplabs/ember-tether#4 before the internal ember-tether + ember-modal-dialog tests will pass in 1.13.
Closes #41.
Fixes #34.