Remove instanceof Ember.View check. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ember 1.13+ Ember.View is a different deprecated class than the parent class of `Ember.Component`, so checking for `t instanceof Ember.View` when `t` was a component would not return true. I discovered this while updating ember-modal-dialog to Ember 1.13. This issue blocks updating that lib.
rwjblue
force-pushed
the
remove-instance-check
branch
from
3f07911
to
bd78d52
Compare
|
Also updated to handle the loss of All green now... |
chrislopresto
added a commit
that referenced
this pull request
Jun 18, 2015
Remove instanceof Ember.View check.
|
Just got caught up by this one - Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ember 1.13+ Ember.View is a different deprecated class than the parent class of
Ember.Component, so checking fort instanceof Ember.Viewwhentwas a component would not return true.I discovered this while updating ember-modal-dialog to Ember 1.13.
This issue blocks updating that lib.