Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existence of .bin dir in pnp dependencies before adding to PATH. #6711

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Check for existence of .bin dir in pnp dependencies before adding to PATH. #6711

merged 3 commits into from
Nov 21, 2018

Conversation

hWorblehat
Copy link
Contributor

Summary

Avoids #6683 in many situations by siginificantly reducing the length that the PATH is increased by.
This issue could still raise its head in some situations, if the user already has a PATH whose length is close to the Windows character limit.

Test plan

@buildsize
Copy link

buildsize bot commented Nov 21, 2018

File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.1 MB 1.1 MB -19 bytes (0%)
yarn-[version].js 4.47 MB 4.47 MB 96 bytes (0%)
yarn-legacy-[version].js 4.66 MB 4.66 MB 94 bytes (0%)
yarn-v[version].tar.gz 1.12 MB 1.11 MB -1.85 KB (0%)
yarn_[version]all.deb 814.75 KB 814.11 KB -654 bytes (0%)

Copy link
Member

@arcanis arcanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will wait for the tests to finish and merge it

@arcanis arcanis merged commit 0d48610 into yarnpkg:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants