Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existence of .bin dir in pnp dependencies before adding to PATH. #6711

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Check for existence of .bin dir in pnp dependencies before adding to PATH. #6711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5577615
Check PnP dep has `.bin` dir before adding to `PATH`
Nov 21, 2018
1090ac9
Update CHANGELOG
Nov 21, 2018
458ed44
Update CHANGELOG.md
arcanis Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ Please add one entry in this file for each change in Yarn's behavior. Use the sa

[#6682](https://github.com/yarnpkg/yarn/pull/6682) - [**Maël Nison**](https://twitter.com/arcanis)

- Decreases the size of the generated `$PATH` environment variable for a better Windows support

[#6683](https://github.com/yarnpkg/yarn/issues/6683) - [**Rowan Lonsdale**](https://github.com/hWorblehat)

## 1.12.3

**Important:** This release contains a cache bump. It will cause the very first install following the upgrade to take slightly more time, especially if you don't use the [Offline Mirror](https://yarnpkg.com/blog/2016/11/24/offline-mirror/) feature. After that everything will be back to normal.
Expand Down
5 changes: 4 additions & 1 deletion src/util/execute-lifecycle-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,10 @@ export async function makeEnv(
continue;
}

pathParts.unshift(`${dependencyInformation.packageLocation}/.bin`);
const binFolder = `${dependencyInformation.packageLocation}/.bin`;
if (await fs.exists(binFolder)) {
pathParts.unshift(binFolder);
}
}

// Note that NODE_OPTIONS doesn't support any style of quoting its arguments at the moment
Expand Down