sync49 #4
Merged
sync49 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on, the nodes are remapped from the `tree`, to ensure the `selection` and `focus` represents the most recent state. This fix ensures that the selection state does not get out of sync. Closes #4585. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
…y: Joshua Bradley <jgbradley1@gmail.com> Signed-off-by: Josh Bradley <jgbradley1@gmail.com>
Signed-off-by: Joshua Bradley <jgbradley1@gmail.com>
Signed-off-by: Joshua Bradley <jgbradley1@gmail.com>
Signed-off-by: Joshua Bradley <jgbradley1@gmail.com>
Signed-off-by: Nathan Ridge <zeratul976@hotmail.com>
Every sidepanel has an header now where the title and a toolbar is shown (if tools are registered for that widget). As an example the control buttons of search in workspace extension are moved to the toolbar. Additionally the tabs of sidebars don't show labels anymore but icons. Fixes #3864 Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Fixes #3456 Updated the `git diff` navigation header to be static (fixed). Currently when there are a lot of changes present in the files changed list, we lose the header when scrolling. This means that the navigation and information present in the header is lost so users must always scroll to the top to access them. This change addresses that issue by providing a new css class and overflowing only the files changed list to be scrollable. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: Feng Qingxue <948699357@qq.com>
Fixes #2788 Set the minimum perfect scrollbar length with the `minScrollbarLength` scrollbar option. Currently in Theia, when there is a lot of vertical height the scrollbar becomes quite small and hard to use. With this change we define a minimum length for the scrollbar so it always remains easily visible for users. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes #3037 Updated the keybindings widget search bar to be static (fixed in place) This makes it a lot easier for users to search the table, without the need to constantly scroll up to re-search. - Fixed minor typos found in variable names. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Adjust the `Open Workspace` button present in the explorer when no workspace is currently opened. Previously, the alignment of the button was off (not centered) and after the change the button was updated to be centered in the widget. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: Feng Qingxue <948699357@qq.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Minor change to the perfect scrollbar width to update to a larger value. The change means that the scrollbar is more accessible, visible and aligns more with the styling present in VSCode. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Fixes #4639 Currently, the `git-diff-widget` does not have a caption (tooltip). This means that when the widget is docked, and it's icon is displayed, no tooltip is shown when hovering while others widget do include it. For the sake of completeness and consistency, the `git-diff-widget` should include a caption. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Fixes #4644 Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
Fixes #4638 Added debug console icon. The icon selected is the same as found from the debug widget to open the debug console. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Fixes #4622 Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Change-Id: I3cef27ba76804cd3194ed81c2d343be9ad9e0282 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
This allow creation of files and folders recursive path. improve validation check, add cancellationtoken separate validation for absolutpath and leading/trailing spaces Signed-off-by: Uni Sayo <unibtc@gmail.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: jbicker <jan.bicker@typefox.io>
…by vscode.version call in a VS Code extension $ yarn run start --vscode-api-version=1.40 (and you'll get 1.40 as API version) note: default value is displayed in help as well Change-Id: I371e3b008f8d9a8bbd9e047dada4f75e1137e17a Signed-off-by: Florent Benoit <fbenoit@redhat.com>
It's useful when embedding README in other pages (usecase = the typedoc) So the logo is displayed nicely. Change-Id: Ic1063d972d13eb52bef1248ccf869e3ec0e01f23 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
…ion that is generating the typedoc for the whole modules Change-Id: I0c47554e1a99e22c7b519c94afa7cfd9be1622a4 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Mitigates the issue by removing all unsanitized information from the response. Signed-off-by: Casey Flynn <caseyflynn@google.com>
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Signed-off-by: Uni Sayo <unibtc@gmail.com>
Fix typo in `registerReferenceProvider` Plug-in API. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Added the Plugin API for `CodeActionKind` `intersects(other: CodeActionKind)` method. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
this path add preview option to EditorOpenerOptions according to 'editor.enablePreview' preference. if editor.enablePreview changed to false will pin all prevew widget. Signed-off-by: yewei <yeweiasia@gmail.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Fixes #4812 - Fixes an issue when calling `copy` from the filesystem when the `source` and `target` destinations are the same. Currently, no check is performed to verify if the paths are different which leads to `fs-extra` throwing an error. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: Rob Moran <rob.moran@arm.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
This is a follow-up ot #2574 which moved semantic highlighting interfaces to a language-agnostic place but left these interfaces behind. Signed-off-by: Nathan Ridge <zeratul976@hotmail.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Rob Moran <rob.moran@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.