Merge pull request #1502 from ydb-platform/bulk-upsert-session-info

* Added session info into `trace.TableSessionBulkUpsertStartInfo`
ydb-platform · Oct 8, 2024 · 21e2304 · 21e2304
2 parents 84e9735 + ed92d7d
commit 21e2304
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Added session info into `trace.TableSessionBulkUpsertStartInfo`
+
 ## v3.84.0
 * Added `meta.WithTraceParent` context modifier for explicit putting traceparent header into grpc calls
 

diff --git a/internal/table/session.go b/internal/table/session.go
@@ -1258,9 +1258,8 @@ func (s *session) BulkUpsert(ctx context.Context, table string, rows value.Value
 	var (
 		a           = allocator.New()
 		callOptions []grpc.CallOption
-		onDone      = trace.TableOnSessionBulkUpsert(
-			s.config.Trace(), &ctx,
-			stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/table.(*session).BulkUpsert"),
+		onDone      = trace.TableOnSessionBulkUpsert(s.config.Trace(), &ctx,
+			stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/table.(*session).BulkUpsert"), s,
 		)
 	)
 	defer func() {

diff --git a/trace/table.go b/trace/table.go
@@ -158,6 +158,8 @@ type (
 		// Safe replacement of context are provided only inside callback function
 		Context *context.Context
 		Call    call
+
+		Session sessionInfo
 	}
 	// Internals: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#internals
 	TableSessionBulkUpsertDoneInfo struct {

diff --git a/trace/table_gtrace.go b/trace/table_gtrace.go