Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added session info into trace.TableSessionBulkUpsertStartInfo #1502

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

TableOnSessionBulkUpsert: changed from func(*Table, *context.Context, call) func(error) to func(*Table, *context.Context, call, sessionInfo) func(error)

compatible changes

TableSessionBulkUpsertStartInfo.Session: added

summary

Base version: v3.84.0 (master)
Cannot suggest a release version.
Incompatible changes were detected.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.95%. Comparing base (84e9735) to head (ed92d7d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   66.96%   66.95%   -0.02%     
==========================================
  Files         353      353              
  Lines       36826    36825       -1     
==========================================
- Hits        24660    24655       -5     
- Misses      11075    11079       +4     
  Partials     1091     1091              
Flag Coverage Δ
experiment 71.08% <100.00%> (-0.02%) ⬇️
go-1.21.x 67.18% <100.00%> (-0.04%) ⬇️
go-1.22.x 64.85% <100.00%> (-0.08%) ⬇️
go-1.23.x 66.90% <100.00%> (-0.05%) ⬇️
integration 53.11% <100.00%> (-0.03%) ⬇️
macOS 40.80% <0.00%> (-0.01%) ⬇️
ubuntu 71.24% <100.00%> (-0.02%) ⬇️
unit 41.24% <0.00%> (+<0.01%) ⬆️
windows 41.22% <0.00%> (-0.01%) ⬇️
ydb-23.3 46.65% <100.00%> (-0.06%) ⬇️
ydb-24.1 53.02% <100.00%> (-0.09%) ⬇️
ydb-24.2 53.00% <100.00%> (-0.01%) ⬇️
ydb-nightly 71.08% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 8, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Oct 8, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Oct 8, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Oct 8, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Oct 8, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@asmyasnikov asmyasnikov merged commit 21e2304 into master Oct 8, 2024
44 checks passed
@asmyasnikov asmyasnikov deleted the bulk-upsert-session-info branch October 8, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants