Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* Added session info into trace.TableSessionBulkUpsertStartInfo #1502

Merged
merged 1 commit into from
Oct 8, 2024
Merged

* Added session info into trace.TableSessionBulkUpsertStartInfo #1502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Added session info into `trace.TableSessionBulkUpsertStartInfo`

## v3.84.0
* Added `meta.WithTraceParent` context modifier for explicit putting traceparent header into grpc calls

Expand Down
5 changes: 2 additions & 3 deletions internal/table/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,9 +1258,8 @@ func (s *session) BulkUpsert(ctx context.Context, table string, rows value.Value
var (
a = allocator.New()
callOptions []grpc.CallOption
onDone = trace.TableOnSessionBulkUpsert(
s.config.Trace(), &ctx,
stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/table.(*session).BulkUpsert"),
onDone = trace.TableOnSessionBulkUpsert(s.config.Trace(), &ctx,
stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/table.(*session).BulkUpsert"), s,
)
)
defer func() {
Expand Down
2 changes: 2 additions & 0 deletions trace/table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ type (
// Safe replacement of context are provided only inside callback function
Context *context.Context
Call call

Session sessionInfo
}
// Internals: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#internals
TableSessionBulkUpsertDoneInfo struct {
Expand Down
3 changes: 2 additions & 1 deletion trace/table_gtrace.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading