Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce importUSER for setting SRS from custom strings. #372

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Introduce importUSER for setting SRS from custom strings. #372

merged 2 commits into from
Mar 26, 2023

Conversation

evetion
Copy link
Collaborator

@evetion evetion commented Mar 24, 2023

Now we can do:

julia> p = ArchGDAL.importUSER("EPSG:4326+3855")
Spatial Reference System: +proj=longlat +datum=WGS84 +geoidgr ... _defs

Note how there's now +geoidgrid present, which represents the vertical transform of EPSG:3855.

@evetion evetion requested a review from visr March 24, 2023 09:25
This was referenced Mar 24, 2023
Merged
Merged
yeesian
yeesian requested changes Mar 25, 2023
View reviewed changes
Copy link
Owner

@yeesian yeesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM apart from bike-shedding on function name(s)

src/spatialref.jl Outdated Show resolved Hide resolved
yeesian
yeesian approved these changes Mar 26, 2023
View reviewed changes
Copy link
Owner

@yeesian yeesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yeesian yeesian merged commit a99fcc0 into master Mar 26, 2023
@yeesian yeesian deleted the feat/user-crs-input branch March 26, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeesian yeesian yeesian approved these changes

@visr visr Awaiting requested review from visr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evetion @yeesian