Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse GeoFormatTypes EPSG with 2 codes #374

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Parse GeoFormatTypes EPSG with 2 codes #374

merged 3 commits into from
Oct 20, 2023

Conversation

evetion
Copy link
Collaborator

@evetion evetion commented Mar 24, 2023

To be merged after #372 and JuliaGeo/GeoFormatTypes.jl#22

@evetion evetion changed the title Introduce importUSER for setting SRS from custom strings. Parse GeoFormatTypes EPSG with 2 codes Mar 24, 2023
Base automatically changed from feat/user-crs-input to master March 26, 2023 01:21
@evetion evetion requested a review from yeesian October 19, 2023 20:29
Copy link
Owner

@yeesian yeesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Out of curiosity: is there any way to look up documentation for EPSG with 2 codes?

@yeesian yeesian merged commit c3148ad into master Oct 20, 2023
14 checks passed
@yeesian yeesian deleted the feat/parse-epsg2 branch October 20, 2023 00:18
@evetion
Copy link
Collaborator Author

evetion commented Oct 20, 2023

Not currently no. It would be a compound CRS, and you can lookup the individual codes. Like the test examples, it would be a combination of a 2D CRS and a vertical one, making it 3d. Some of those combinations are common, and have their own code: 4326+3855 == 9518.

Maybe the Proj.identify function could help with this, but it doesn't yet know about the EPSG{2} convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants