Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Use split_for_impl in the "derive props" macro #573

Closed
jstarry opened this issue Aug 9, 2019 · 2 comments · Fixed by #580
Closed

Cleanup: Use split_for_impl in the "derive props" macro #573

jstarry opened this issue Aug 9, 2019 · 2 comments · Fixed by #580

Comments

@jstarry
Copy link
Member

jstarry commented Aug 9, 2019

Wasn't aware of this method when writing the proc macro for deriving the Properties trait: https://docs.rs/syn/0.15.43/syn/struct.Generics.html#method.split_for_impl
@jstarry
Copy link
Member Author

jstarry commented Aug 9, 2019

@totorigolo if you're enjoying the proc macro work, it'd be great if you could take this on!

@totorigolo
Copy link
Contributor

This time I think that you will be faster than me doing the change 😄

@jstarry jstarry mentioned this issue Aug 11, 2019
Merged
bors bot added a commit that referenced this issue Aug 11, 2019
@bors @jstarry
Merge #580
839d4fb 
580: Add lifetime support to derive props macro r=jstarry a=jstarry

Fixes: #573

Co-authored-by: Justin Starry <jstarry@users.noreply.github.com>
@bors bors bot closed this as completed in #580 Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lifetime support to derive props macro jstarry/yew
2 participants
@jstarry @totorigolo