Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lifetime support to derive props macro #580

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Add lifetime support to derive props macro #580

merged 1 commit into from
Aug 11, 2019

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Aug 11, 2019

Fixes: #573

@jstarry jstarry force-pushed the derive_props_lifetimes branch from a2298d6 to 5c155ef Compare August 11, 2019 21:37
@jstarry jstarry force-pushed the derive_props_lifetimes branch from 5c155ef to 74373e6 Compare August 11, 2019 21:39
@jstarry
Copy link
Member Author

jstarry commented Aug 11, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 11, 2019
@bors @jstarry
Merge #580
839d4fb 
580: Add lifetime support to derive props macro r=jstarry a=jstarry

Fixes: #573

Co-authored-by: Justin Starry <jstarry@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 11, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 74373e6 into yewstack:master Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup: Use split_for_impl in the "derive props" macro
1 participant
@jstarry