You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, often required a method to send messages itself to a component immediately.
This PR adds: send_self method and add a requirement for a mutable reference to send_back method.
I'd prefer if this was kept without mut. I've been creating Callbacks with send_back in the view method to pass them down as props to avoid that the Model gets too cluttered.
... but I haven't seen this needs in my work. Could you explain, why do you need callbacks in properties? You should prefer to use agents to communicate components.
@deniskolodin I haven't used agents yet but I'll explore using them for this instead.
Being more familiar with react I've used callbacks to allow child components to notify their parents about changes related to props e.g. a child with an input informs the parent about a text change and has it update its state and rerender.
365: Add send_self method r=DenisKolodin a=DenisKolodin
In practice, often required a method to send messages itself to a component immediately.
This PR adds: `send_self` method and add a requirement for a mutable reference to `send_back` method.
Co-authored-by: Denis Kolodin <deniskolodin@gmail.com>
367: Require mutable reference for send_back method call r=DenisKolodin a=DenisKolodin
This PR is separated from #365 to buy time to make backward incompatible changes.
Co-authored-by: Denis Kolodin <deniskolodin@gmail.com>
borsbot
added a commit
that referenced
this pull request
Aug 27, 2018
367: Require mutable reference for send_back method call r=DenisKolodin a=DenisKolodin
This PR is separated from #365 to buy time to make backward incompatible changes.
Co-authored-by: Denis Kolodin <deniskolodin@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice, often required a method to send messages itself to a component immediately.
This PR adds:
send_selfmethod and add a requirement for a mutable reference tosend_backmethod.