Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require mutable reference for send_back method call #367

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Require mutable reference for send_back method call #367

merged 1 commit into from
Aug 27, 2018

Conversation

therustmonk
Copy link
Member

@therustmonk therustmonk commented Aug 20, 2018 •
edited
Loading

This PR is separated from #365 to buy time to make backward incompatible changes.

@therustmonk therustmonk mentioned this pull request Aug 20, 2018
Merged
@therustmonk
Copy link
Member Author

Important! This PR prevents of creating and calling callbacks in view methods.

bors bot added a commit that referenced this pull request Aug 27, 2018
@bors @therustmonk
Merge #367
eda8353 
367: Require mutable reference for send_back method call r=DenisKolodin a=DenisKolodin

This PR is separated from #365 to buy time to make backward incompatible changes.

Co-authored-by: Denis Kolodin <deniskolodin@gmail.com>
@yewstack yewstack deleted a comment from bors bot Aug 27, 2018
@therustmonk
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 27, 2018
@bors @therustmonk
Merge #367
a2ebc25 
367: Require mutable reference for send_back method call r=DenisKolodin a=DenisKolodin

This PR is separated from #365 to buy time to make backward incompatible changes.

Co-authored-by: Denis Kolodin <deniskolodin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 27, 2018

Build succeeded

@bors bors bot merged commit 07573eb into master Aug 27, 2018
@therustmonk therustmonk deleted the link-mut branch August 11, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@therustmonk