Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows prebuilds for Node 16 LTS #284

Closed

Conversation

miroslavpokorny
Copy link

Description

Builded windows prebuilds for node.js 16 using command in prebuilds/README.md

Motivation and Context

Node 16 is active LTS starting from 26th October 2021.
With prebuilds it is not necessary to install c++ build tools on target machine.

How Has This Been Tested?

Newly created prebuild for windows copyed to node_modules/zookeeper/prebuilds directory on machine without c++ build tools. Application using zookeeper module started without error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic
Copy link
Collaborator

Thank you @miroslavpokorny!

I will review this as soon as possible.

@DavidVujic DavidVujic self-requested a review December 6, 2021 16:15
@DavidVujic
Copy link
Collaborator

Hello again @miroslavpokorny!

I will create a separate pull request for this, including binaries for Mac OS X.

As a maintainer I will create new binaries for security reasons. But I have added you as a co-author and will of course also add your name to the changelog. I hope it is okay doing this way!

Thank you again for making a pull request, much appreciated!

@DavidVujic
Copy link
Collaborator

Here's the Co-authored-by commit: 049ccd8

And the changelog: https://github.com/yfinkelstein/node-zookeeper/blob/master/CHANGELOG.md#v-500-2021-12-06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants