Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prebuilds for Node.js 16 (current LTS version) #285

Merged
merged 8 commits into from
Dec 6, 2021

Conversation

DavidVujic
Copy link
Collaborator

Add Windows and Mac OS X prebuilds for Node.js 16.

Co-authored by and originated from this Pull Request by @miroslavpokorny : #284

Description

New prebuilds for Node.js 16.

Drop prebuilds for Node.js 12.
Add CI test builds for Node.js 16, and remove for Node.js 12.

Motivation and Context

The current LTS of Node.js is v16 and supporting the latest two LTS versions should be good enough.

How Has This Been Tested?

Travis CI builds passed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic
Copy link
Collaborator Author

In the Travis CI logs for Mac OS X and Node.js 16: looks like it doesn't pick up the prebuild. 🤔

Running locally on an iMac works as expected. Is the machine in the CI using an M1 processor?

@DavidVujic
Copy link
Collaborator Author

Update: the Mac OS X prebuilds are for x64 and that is why Travis CI will run a full build. I will create a separate PR for supporting arm64 (M1 processor).

@DavidVujic DavidVujic merged commit 7feeaac into yfinkelstein:master Dec 6, 2021
@DavidVujic DavidVujic deleted the node_16 branch December 6, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants